This repository was archived by the owner on Nov 4, 2023. It is now read-only.
Bugfix: Samsung Galaxy S3 - Android Browser - Databuffer Boundary Bugfix #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Android Browser in my Samsung Galaxy S3 (Android 4.4.2) does have a problem that I haven't encountered in other Browsers: Creating a buffer view with an buffer that has a size that isn't a multiple of the base type creates an Exception: ArrayBuffer length minus the byteOffset is not a multiple of the element size This happened to me in a game where I'm loading a Binary File. Of course it is possible that the size of this Binary File isn't a multiple of 4. Now when Monkey tries to load in the File into a DataBuffer object the above-mentioned Exception is thrown. I've created a workaround in this pull request because I weren't able to come up with a cleaner solution: If the length of the buffer isn't a multiple of 4, I copy/resize the buffer to be a multiple of 4 in length. But I keep the original length property so that the seeking logic remains the same.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Android Browser in my Samsung Galaxy S3 (Android 4.4.2) does have a
problem that I haven't encountered in other Browsers:
Creating a buffer view with an buffer that has a size that isn't
a multiple of the base type creates an Exception:
ArrayBuffer length minus the byteOffset is not a multiple of the element size
This happened to me in a game where I'm loading a Binary File. Of course
it is possible that the size of this Binary File isn't a multiple of 4.
Now when Monkey tries to load in the File into a DataBuffer object the
above-mentioned Exception is thrown.
I've created a workaround in this pull request because I weren't able
to come up with a cleaner solution:
If the length of the buffer isn't a multiple of 4, I copy/resize the
buffer to be a multiple of 4 in length.
But I keep the original length property so that the seeking logic
remains the same.