-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] feat: Allow props to be exported from other files #122
base: main
Are you sure you want to change the base?
Conversation
@alii thanks a lot for working on this! There's a lot of changes unrelated to the original issue, that's making it hard for me to review. Can I ask you to revert the import changes you made, so this PR is more contained? That'd give me the confidence that I'm not missing anything while reviewing. |
@Skn0tt The import changes were due to a type mismatch between |
Interesting! Yeah, reverting would be nice. |
I'll look at that type mismatch separately, that sounds interesting |
@Skn0tt do you need some help with this one? I would love to see it merged! |
@apieceofbart this PR contains a lot of unrelated changes, which is why I'm not moving forward with it. if you want to work on it, I think it'd be best to open a new PR :) |
cool, yeah, I'll give it a try especially that a lot of code is already written :) |
Ohh I'm really sorry haha, I'm not sure why I never completed this. I think I did have the changes locally but didn't push for some reason. Happy to help as well @apieceofbart if you need a hand. :D |
@alii I only checked briefly yesterday - tried to be smart and copy your code but without the type changes part. Unfortunately when I did this there were a couple of TS errors. What is weird is that when I open |
I think that was the reason I ended up updating all of the dependencies in my branch, because there were a lot of type mismatches between them. @apieceofbart iirc, the things I deps I moved around here fixed those issues |
Fixes #121 and allows for props to exported in the following manner