Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/restore-snapshot #30

Merged
merged 32 commits into from
Nov 18, 2024
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
69848e5
feat: provide option to run the handler locally as API
TimPietrusky Feb 11, 2024
e3de2fa
ci: run the workflow on our extended instance
TimPietrusky Feb 11, 2024
fb17089
feat: the local API should run on 0.0.0.0
TimPietrusky Feb 11, 2024
e748931
feat: make the image smaller
TimPietrusky Feb 11, 2024
8f5a379
ci: use semantic-version to create releases automatically
TimPietrusky Feb 12, 2024
f66b2ca
chore: we don't want to break anyone with a minor release
TimPietrusky Feb 12, 2024
b6972f3
docs: added section for local API testing
TimPietrusky Feb 12, 2024
fea12e8
ci: use custom runner
TimPietrusky Feb 12, 2024
d603c91
fix: added .releaserc, otherwise semantic-release will complain about…
TimPietrusky Feb 12, 2024
f11dbef
Merge branch 'main' into dev
TimPietrusky Feb 12, 2024
e4276de
feat: support network volumes, skip default models (#16)
Meptl Feb 20, 2024
201f64e
feat: provide access to ComfyUI via web
TimPietrusky Mar 19, 2024
4b48ef0
fix: use the full path to the output image
TimPietrusky Mar 19, 2024
18c510c
feat: added env vars COMFY_POLLING_INTERVAL_MS and COMFY_POLLING_MAX_…
TimPietrusky Mar 19, 2024
5435d6c
test: added "subfolder"
TimPietrusky Mar 19, 2024
c7747ce
Implement optional restoring of ComfyUI snapshots
kklemon Apr 1, 2024
6d67d7e
feat: use comfy-cli to install ComfyUI & restore snapshot
TimPietrusky Nov 16, 2024
926a6a1
fix: install all dependencies from the snapshot
TimPietrusky Nov 17, 2024
c949e94
chore: moved example snapshot to test_resources
TimPietrusky Nov 17, 2024
6a83143
feat: allow any kind of snapshot file
TimPietrusky Nov 17, 2024
9926f75
feat: allow any file that has "snapshot" in its name
TimPietrusky Nov 17, 2024
7607a43
ci: added test for "restore-snapshot"
TimPietrusky Nov 17, 2024
a6b0c6b
Merge branch 'main' into feat/snapshot-restoring
TimPietrusky Nov 17, 2024
07c5a8c
ci: run restore snapshat test automatically
TimPietrusky Nov 17, 2024
4e3e76d
docs: use "snapshots" to bake custom nodes into the docker image
TimPietrusky Nov 17, 2024
3f2daef
docs: add link to ComfyUI Manager docs on how to export snapshots
TimPietrusky Nov 17, 2024
7ed6c19
ci: use correct path to example_snapshot.json
TimPietrusky Nov 18, 2024
0b2bcd1
ci: fix the path
TimPietrusky Nov 18, 2024
cf24d23
ci: fix the file path
TimPietrusky Nov 18, 2024
0393d84
ci: use a mock instead of the actual file
TimPietrusky Nov 18, 2024
473f4f3
ci: fix the path
TimPietrusky Nov 18, 2024
f3929cb
chore: don't ignore snapshot.json as people might use this
TimPietrusky Nov 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: provide option to run the handler locally as API
TimPietrusky committed Feb 11, 2024

Verified

This commit was signed with the committer’s verified signature.
pylapp Pierre-Yves Lapersonne
commit 69848e502723d99157075297c5849f0021efe248
7 changes: 4 additions & 3 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -2,12 +2,13 @@ version: "3.8"

services:
comfyui:
image: timpietruskyblibla/runpod-worker-comfy:1.0.0
image: timpietruskyblibla/runpod-worker-comfy:latest
container_name: comfyui-worker
environment:
- NVIDIA_VISIBLE_DEVICES=all
env_file:
- .env
- SERVE_API_LOCALLY=true
ports:
- "8000:8000"
runtime: nvidia
volumes:
- ./data/comfyui/output:/comfyui/output
8 changes: 7 additions & 1 deletion src/start.sh
Original file line number Diff line number Diff line change
@@ -8,4 +8,10 @@ echo "runpod-worker-comfy: Starting ComfyUI"
python3 /comfyui/main.py --disable-auto-launch --disable-metadata &

echo "runpod-worker-comfy: Starting RunPod Handler"
python3 -u /rp_handler.py

# Serve the API and don't shutdown the container
if [ "$SERVE_API_LOCALLY" == "true" ]; then
python3 -u /rp_handler.py --rp_serve_api
else
python3 -u /rp_handler.py
fi