Gitealize usernames #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be merged into |
|
Also getting an error when trying to approve this PR for some reason. But LGTM, you can take this comment as approval. |
Blender ID allows a wider range of characters in the nickname than Gitea allows. Before using a Blender ID nickname as a Gitea username, it needs to be massaged into a valid form. This was already done in the Blender ID-to-Gitea webhook for username changes, and this PR introduces it in Gitea itself for the registration flow. The implementation follows what the webhook code[1] does, except it's simpler because it can use built-in Gitea functionality. This fixes https://projects.blender.org/blender/blender/issues/111937 [1]: https://projects.blender.org/infrastructure/gitea-blenderid-webhook/src/branch/main/gitea_blenderid_webhook/gitea_users.py
drsybren
force-pushed
the
pr-gitealize-usernames
branch
from
a5c9322
to
417887d
Compare
drsybren
changed the base branch from
blender-merged
to
blender-merged-develop
drsybren
added a commit
that referenced
this pull request
Sep 7, 2023
Blender ID allows a wider range of characters in the nickname than Gitea allows. Before using a Blender ID nickname as a Gitea username, it needs to be massaged into a valid form. This was already done in the Blender ID-to-Gitea webhook for username changes, and this PR introduces it in Gitea itself for the registration flow. The implementation follows what the webhook code[1] does, except it's simpler because it can use built-in Gitea functionality. This fixes https://projects.blender.org/blender/blender/issues/111937 [1]: https://projects.blender.org/infrastructure/gitea-blenderid-webhook/src/branch/main/gitea_blenderid_webhook/gitea_users.py Reviewed on: #3
|
Manually merged as 302ab38 |
brechtvl
pushed a commit
that referenced
this pull request
May 10, 2024
…28336) This resolves a problem I encountered while updating gitea from 1.20.4 to 1.21. For some reason (correct or otherwise) there are some values in `repository.size` that are NULL in my gitea database which cause this migration to fail due to the NOT NULL constraints. Log snippet (excuse the escape characters) ``` ESC[36mgitea |ESC[0m 2023-12-04T03:52:28.573122395Z 2023/12/04 03:52:28 ...ations/migrations.go:641:Migrate() [I] Migration[263]: Add git_size and lfs_size columns to repository table ESC[36mgitea |ESC[0m 2023-12-04T03:52:28.608705544Z 2023/12/04 03:52:28 routers/common/db.go:36:InitDBEngine() [E] ORM engine initialization attempt #3/10 failed. Error: migrate: migration[263]: Add git_size and lfs_size columns to repository table failed: NOT NULL constraint failed: repository.git_size ``` I assume this should be reasonably safe since `repository.git_size` has a default value of 0 but I don't know if that value being 0 in the odd situation where `repository.size == NULL` has any problematic consequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blender ID allows a wider range of characters in the nickname than Gitea allows. Before using a Blender ID nickname as a Gitea username, it needs to be massaged into a valid form.
This was already done in the Blender ID-to-Gitea webhook for username changes, and this PR introduces it in Gitea itself for the registration flow.
The implementation follows what the webhook code does, except it's simpler because it can use built-in Gitea functionality.
This fixes https://projects.blender.org/blender/blender/issues/111937