-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for add_on_usage #130
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for contributing!
I will need to give this one more (thorough) pass as I am tight on time, but I wanted to leave some initial comments in the meantime on a few changes that stood out to me right away.
Hi! I answered your questions and fixed what you requested. I'm terrible sorry that I did this 8 days after your request, but I was on vacation. Thanks and let me know if any further information are needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes applied (Still query -> Query) to be resolved.
Hi there! Thank you for checking and reviewing my attempt for to add_on_usage support in you library. Thanks! |
Hi @ordo-viddler, apologies for the delay as I've been very busy. I really appreciate the PR -- the holdup has been mostly thinking about the |
Hi Sure, I just wanted to keep things clean. |
Here is my attempt to implement add_on_usage: https://dev.recurly.com/docs/usage-record-object.
Couple things I would like you to be sure to check:
Thank you.