Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TravisCI configuration #11

Closed
wants to merge 29 commits into from

Conversation

EmanueleMinotto
Copy link

Added TravisCI configuration to speed up the integration of new changes.

Related: #5

- composer self-update

install:
- composer install --prefer-source --no-interaction --no-progress
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about removing --prefer-source and also cache the Composer cache files between builds?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included the --prefer-source because could be useful if some dependencies' development tools want be used, for example the Guzzle tests/server.js, so it's up to this repo owner, imo it's just a decision.

Composer cache: 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if I am not mistaken, caching the Composer cache files won't work when installing from source instead of from dist.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I didn't see the related PR, do you suggest to add the --prefer-dist and something to configure the token too?

cache:
directories:
- vendor
- $HOME/.composer/cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.composer/cache/files would be enough, to avoid invalidating the cache because of Packagist metadata


cache:
directories:
- vendor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not cache the vendor folder:

  • it can create weird issues if the cache gets corrupted, as Composer will still see the packages as being here
  • it will invalidate the Travis cache on each build due to the autoloader being regenerated
  • it does not bring much benefit, as installing archives from the cache is fast already

@EmanueleMinotto
Copy link
Author

Fixed with feedbacks, thanks @stof and @xabbuh

@stof
Copy link
Contributor

stof commented Dec 21, 2015

👍

1 similar comment
@romainneutron
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants