Re-export ParseIrOpt to ease custom implementations of FromValue#384
Open
LeoniePhiline wants to merge 1 commit intoblackbeam:masterfrom
Open
Re-export ParseIrOpt to ease custom implementations of FromValue#384LeoniePhiline wants to merge 1 commit intoblackbeam:masterfrom
ParseIrOpt to ease custom implementations of FromValue#384LeoniePhiline wants to merge 1 commit intoblackbeam:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to implement
FromValuefor a custom type, based onParseIrOpt<bool>, I noticed thatParseIrOptis not re-exported.Needing to add
mysql_commonas direct dependency causes overhead, as compatible version updates must be coordinated. (For example, the currentmysql_async0.36 requiresmysql_common0.35, while a newermysql_common0.36 would be available.)Re-exporting
ParseIrOptallows users ofmysql_asyncto implementFromValuefor custom types without needing to manage this added dependency.