Lower log level of events that are typically handled by application #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @blackbeam,
I'm opening this PR to present an issue that I'm having with
mysql_async.Currently, this crate is emitting all
Errvariants aserror!events.Most of the time this is desirable, but sometimes this level is too severe.
When inserting duplicate values, deleting a value that is in use by another table, matching the
Errvariant is very convenient. A query that returnsErrcould be a benign error that is handled by the application, and a lower event level would be better.This PR matches the
ServerErrorand looks at its error code to decide whether to emit anerror!or awarn!.