Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple message comments in nested calls #304

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

bkryza
Copy link
Owner

@bkryza bkryza commented Aug 12, 2024

Fixes #301

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.05970% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.49%. Comparing base (7df74e7) to head (34e1012).

Files Patch % Lines
src/common/generators/plantuml/generator.h 16.66% 5 Missing ⚠️
src/common/visitor/ast_id_mapper.cc 85.71% 1 Missing ⚠️
src/sequence_diagram/model/message.cc 94.11% 1 Missing ⚠️
...quence_diagram/visitor/translation_unit_visitor.cc 95.65% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   90.47%   90.49%   +0.01%     
==========================================
  Files         123      123              
  Lines       13801    13803       +2     
==========================================
+ Hits        12487    12491       +4     
+ Misses       1314     1312       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkryza bkryza merged commit 2f11e5f into master Aug 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix double message comments in conditional statements
2 participants