Fix: Only adjust view rect if it uses custom FrameBuffer with textures using BackbufferRatio #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheTryton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case a framebuffer would be created with textures with custom dimensions instead of using BackbufferRatio the existing code can write incorrect predefined uniforms to the shaders. In a case that the window has 1280x720 resolution (m_resolution = {1280, 720}) and the custom framebuffer being set to textures with 3840x2160 resolution the existing code will adjust the m_view from any value set in the user code to {*, *, 1280, 720} thus putting several invalid predefined uniforms in the shaders.
This fix should only do that for framebuffers that are related to the m_resolution using the BackbufferRatio feature, other ones are ignored and the m_view value is not touched.