Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for list of pure resources #314

Closed
via-justa opened this issue Apr 6, 2024 · 3 comments · Fixed by #335
Closed

Add support for list of pure resources #314

via-justa opened this issue Apr 6, 2024 · 3 comments · Fixed by #335
Assignees
Labels
enhancement New feature or request

Comments

@via-justa
Copy link

Details

Describe the solution you'd like:
I love this Helm chart and use it to deploy almost all of my applications.
As I am more on the power user side, I use custom resources (some developed by me and some from upstream, like OnePasswordItem) and would love the ability to deploy them alongside the other resources.

The easiest solution for deploying unknown custom resource by the chart is to add an otherResources section that accepts a list of K8s API objects that the chart renders as-is.

Anything else you would like to add:

Additional Information:

@via-justa via-justa added the enhancement New feature or request label Apr 6, 2024
@onedr0p
Copy link
Contributor

onedr0p commented Apr 15, 2024

This was brought up in #56 and I am not sure if anything has changed on wanting to implement this.

@onedr0p
Copy link
Contributor

onedr0p commented Apr 15, 2024

Adding this could ease the burden of supporting any unsupported resource like in the linked issues above.

@via-justa
Copy link
Author

@onedr0p or @bjw-s, would you mind elaborating on this comment?
What do you mean by saying

Resources not supported by the library chart should be deployed as sidecar manifests

Deploying chart dependencies outside the chart is Helm's antipattern, and the developers discourage it. Or do you mean something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants