Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for prometheusRule #133

Open
reefland opened this issue Apr 13, 2023 · 3 comments · May be fixed by #335
Open

Support for prometheusRule #133

reefland opened this issue Apr 13, 2023 · 3 comments · May be fixed by #335
Assignees
Labels
enhancement New feature or request

Comments

@reefland
Copy link

Details

I would like the common chart to be able to support prometheusRule, which goes nicely with the existing serviceMonitor.

Example:

# -- Enable and configure Prometheus Rules for the chart under this key.
prometheusRule:
  enabled: true
  labels: {}
  # -- Configure additionial rules for the chart under this key.
  rules:
    - alert: SonarrDown
      annotations:
      description: Sonarr service is down.
      summary: Sonarr is down.
      expr: |
        sonarr_system_status == 0
        for: 5m
        labels:
          severity: critical

Anything else you would like to add:

Additional Information:

@reefland reefland added the enhancement New feature or request label Apr 13, 2023
@bjw-s
Copy link
Owner

bjw-s commented May 8, 2023

Hi! Thanks for the feature request! I will add this to the rewrite that I am working on. Unfortunately time has not been on my side so progress has been a bit slower than I'd hoped.

@bjw-s bjw-s added this to the common-2.0.0 milestone May 8, 2023
@bjw-s bjw-s removed this from the common-2.0.0 milestone Mar 23, 2024
@onedr0p
Copy link
Contributor

onedr0p commented Apr 15, 2024

I wonder if it's better to allow for this #314 ?

@MacroPower
Copy link
Sponsor

Not sure if it helps but I had intended to PR this back and just never got around to it

template: MacroPower/helm-charts@441a2cf

tests: MacroPower/helm-charts@b5bc456

usage: MacroPower/helm-charts@262eb7c

@bjw-s bjw-s linked a pull request Jun 27, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants