Skip to content

Commit

Permalink
🤖 Merge PR DefinitelyTyped#60055 [node] Improve consistency of JSDoc …
Browse files Browse the repository at this point in the history
…since tags by @josh-

* Update consistency of since tags in node

* Fix typo
  • Loading branch information
josh- authored Apr 26, 2022
1 parent 1ca333e commit ecdd55d
Show file tree
Hide file tree
Showing 12 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion types/node/async_hooks.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ declare module 'async_hooks' {
* @param type The type of async event.
* @param triggerAsyncId The ID of the execution context that created
* this async event (default: `executionAsyncId()`), or an
* AsyncResourceOptions object (since 9.3)
* AsyncResourceOptions object (since v9.3.0)
*/
constructor(type: string, triggerAsyncId?: number | AsyncResourceOptions);
/**
Expand Down
4 changes: 2 additions & 2 deletions types/node/globals.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -272,11 +272,11 @@ declare namespace NodeJS {
id: string;
filename: string;
loaded: boolean;
/** @deprecated since 14.6.0 Please use `require.main` and `module.children` instead. */
/** @deprecated since v14.6.0 Please use `require.main` and `module.children` instead. */
parent: Module | null | undefined;
children: Module[];
/**
* @since 11.14.0
* @since v11.14.0
*
* The directory name of the module. This is usually the same as the path.dirname() of the module.id.
*/
Expand Down
2 changes: 1 addition & 1 deletion types/node/v12/async_hooks.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ declare module 'async_hooks' {
* @param type The type of async event.
* @param triggerAsyncId The ID of the execution context that created
* this async event (default: `executionAsyncId()`), or an
* AsyncResourceOptions object (since 9.3)
* AsyncResourceOptions object (since v9.3.0)
*/
constructor(type: string, triggerAsyncId?: number|AsyncResourceOptions);

Expand Down
8 changes: 4 additions & 4 deletions types/node/v12/globals.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,11 @@ interface NodeModule {
id: string;
filename: string;
loaded: boolean;
/** @deprecated since 12.19.0 Please use `require.main` and `module.children` instead. */
/** @deprecated since v12.19.0 Please use `require.main` and `module.children` instead. */
parent: NodeModule | null | undefined;
children: NodeModule[];
/**
* @since 11.14.0
* @since v11.14.0
*
* The directory name of the module. This is usually the same as the path.dirname() of the module.id.
*/
Expand Down Expand Up @@ -1317,11 +1317,11 @@ declare namespace NodeJS {
id: string;
filename: string;
loaded: boolean;
/** @deprecated since 12.19.0 Please use `require.main` and `module.children` instead. */
/** @deprecated since v12.19.0 Please use `require.main` and `module.children` instead. */
parent: Module | null | undefined;
children: Module[];
/**
* @since 11.14.0
* @since v11.14.0
*
* The directory name of the module. This is usually the same as the path.dirname() of the module.id.
*/
Expand Down
2 changes: 1 addition & 1 deletion types/node/v12/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

// NOTE: These definitions support NodeJS and TypeScript 3.7.
// This isn't strictly needed since 3.7 has the assert module, but this way we're consistent.
// Typically type modificatons should be made in base.d.ts instead of here
// Typically type modifications should be made in base.d.ts instead of here

// Reference required types from the default lib:
/// <reference lib="es2018" />
Expand Down
2 changes: 1 addition & 1 deletion types/node/v12/inspector.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1917,7 +1917,7 @@ declare module 'inspector' {
* Connects a session to the main thread inspector back-end.
* An exception will be thrown if this API was not called on a Worker
* thread.
* @since 12.11.0
* @since v12.11.0
*/
connectToMainThread(): void;

Expand Down
2 changes: 1 addition & 1 deletion types/node/v14/async_hooks.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ declare module 'async_hooks' {
* @param type The type of async event.
* @param triggerAsyncId The ID of the execution context that created
* this async event (default: `executionAsyncId()`), or an
* AsyncResourceOptions object (since 9.3)
* AsyncResourceOptions object (since v9.3.0)
*/
constructor(type: string, triggerAsyncId?: number|AsyncResourceOptions);

Expand Down
4 changes: 2 additions & 2 deletions types/node/v14/globals.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -724,11 +724,11 @@ declare namespace NodeJS {
id: string;
filename: string;
loaded: boolean;
/** @deprecated since 14.6.0 Please use `require.main` and `module.children` instead. */
/** @deprecated since v14.6.0 Please use `require.main` and `module.children` instead. */
parent: Module | null | undefined;
children: Module[];
/**
* @since 11.14.0
* @since v11.14.0
*
* The directory name of the module. This is usually the same as the path.dirname() of the module.id.
*/
Expand Down
2 changes: 1 addition & 1 deletion types/node/v14/inspector.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1917,7 +1917,7 @@ declare module 'inspector' {
* Connects a session to the main thread inspector back-end.
* An exception will be thrown if this API was not called on a Worker
* thread.
* @since 12.11.0
* @since v12.11.0
*/
connectToMainThread(): void;

Expand Down
2 changes: 1 addition & 1 deletion types/node/v16/async_hooks.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ declare module 'async_hooks' {
* @param type The type of async event.
* @param triggerAsyncId The ID of the execution context that created
* this async event (default: `executionAsyncId()`), or an
* AsyncResourceOptions object (since 9.3)
* AsyncResourceOptions object (since v9.3.0)
*/
constructor(type: string, triggerAsyncId?: number | AsyncResourceOptions);
/**
Expand Down
4 changes: 2 additions & 2 deletions types/node/v16/globals.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,11 @@ declare namespace NodeJS {
id: string;
filename: string;
loaded: boolean;
/** @deprecated since 14.6.0 Please use `require.main` and `module.children` instead. */
/** @deprecated since v14.6.0 Please use `require.main` and `module.children` instead. */
parent: Module | null | undefined;
children: Module[];
/**
* @since 11.14.0
* @since v11.14.0
*
* The directory name of the module. This is usually the same as the path.dirname() of the module.id.
*/
Expand Down
2 changes: 1 addition & 1 deletion types/node/v16/inspector.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1782,7 +1782,7 @@ declare module 'inspector' {
* Connects a session to the main thread inspector back-end.
* An exception will be thrown if this API was not called on a Worker
* thread.
* @since 12.11.0
* @since v12.11.0
*/
connectToMainThread(): void;
/**
Expand Down

0 comments on commit ecdd55d

Please sign in to comment.