Add missing unsigned final arg of Long.fromValue definition (Defini…

…telyTyped#59976) Compare the source definition in 4.0.0: https://github.com/dcodeIO/long.js/blob/941c5c62471168b5d18153755c2a7b38d2560e58/src/long.js#L273-L280 to the type: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/eb48acf05bf3bf7197c5a3e55972530634a6d3bd/types/long/index.d.ts#L99-L102 `fromValue` can optionally accept a second `unsigned` arg.
bjubes · Apr 26, 2022 · b8d5209 · b8d5209
1 parent 839e3be
commit b8d5209
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/types/long/index.d.ts b/types/long/index.d.ts
@@ -99,7 +99,7 @@ declare namespace Long {
         /**
          * Converts the specified value to a Long.
          */
-        fromValue( val: Long | number | string | {low: number, high: number, unsigned: boolean} ): Long;
+        fromValue( val: Long | number | string | {low: number, high: number, unsigned: boolean}, unsigned?: boolean ): Long;
     }
     interface Long
     {

diff --git a/types/long/long-tests.ts b/types/long/long-tests.ts
@@ -66,6 +66,11 @@ b = val.lessThanOrEqual(n);
 b = val.lessThanOrEqual(s);
 
 val = Long.fromValue(10);
+val = Long.fromValue('10');
+val = Long.fromValue(10, true);
+val = Long.fromValue('10', true);
+val = Long.fromValue({ low: 1, high: 1, unsigned: true });
+val = Long.fromValue({ low: 1, high: 1, unsigned: true }, true);
 val = val.modulo(val);
 val = val.modulo(n);
 val = val.modulo(s);