Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample earthquake example #382

Merged
merged 5 commits into from
Jul 15, 2023

Conversation

tkoyama010
Copy link
Collaborator

🚀 Pull Request

See #373

Description

Add an earthquake sample. This is not perfect (We need to express the scalar by the color of size) but good to go.

01


@github-actions github-actions bot added type: examples Auto-labelled for ex/*, example/* and examples/* branches type: enhancement Auto-labelled for feat/* and feature/* branches labels Jul 15, 2023
@tkoyama010
Copy link
Collaborator Author

pre-commit.ci autofix

@tkoyama010
Copy link
Collaborator Author

pre-commit.ci autofix

@bjlittle bjlittle self-assigned this Jul 15, 2023
@bjlittle bjlittle self-requested a review July 15, 2023 22:56
@tkoyama010
Copy link
Collaborator Author

pre-commit.ci autofix

Copy link
Owner

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tkoyama010 Thanks, this is amazing! 🤩

I'm reconsidering bringing back geovista.geoplotter.GeoPlotter.add_points as a convenience so that you can simply pass in the longitudes and latitudes and the conversion to cartesian is done for you. I'll have a think about this.

Plus auto-scaling the points when zooming might be a future consideration.

Anyways, I really love this contribution. It's super cool! 💯 🍻

@bjlittle bjlittle merged commit 1447094 into bjlittle:main Jul 15, 2023
13 checks passed
@tkoyama010 tkoyama010 deleted the feat/add-earthquake-example branch July 16, 2023 04:31
@bjlittle
Copy link
Owner

@all-contributors please add @tkoyama010 for code, data, example, ideas

Copy link
Contributor

@bjlittle

I've put up a pull request to add @tkoyama010! 🎉

@tkoyama010
Copy link
Collaborator Author

@allcontributors
please add @bjlittle eventOrganizing
please add @tkoyama010 eventOrganizing

Copy link
Contributor

@tkoyama010

@tkoyama010
Copy link
Collaborator Author

@allcontributors
please add @bjlittle for eventOrganizing
please add @tkoyama010 for eventOrganizing

@tkoyama010
Copy link
Collaborator Author

@allcontributors
please add @tkoyama010 for eventOrganizing

Copy link
Contributor

@tkoyama010

@tkoyama010 already contributed before to eventOrganizing

Copy link
Contributor

@tkoyama010

I've put up a pull request to add @bjlittle! 🎉

I've put up a pull request to add @tkoyama010! 🎉

@tkoyama010
Copy link
Collaborator Author

@allcontributors
please add @bjlittle for mentoring

Copy link
Contributor

@tkoyama010

I've updated the pull request to add @bjlittle! 🎉

@tkoyama010
Copy link
Collaborator Author

I've updated

Oh. You are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scipy 2023 type: enhancement Auto-labelled for feat/* and feature/* branches type: examples Auto-labelled for ex/*, example/* and examples/* branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants