-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample earthquake example #382
Add sample earthquake example #382
Conversation
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkoyama010 Thanks, this is amazing! 🤩
I'm reconsidering bringing back geovista.geoplotter.GeoPlotter.add_points
as a convenience so that you can simply pass in the longitudes and latitudes and the conversion to cartesian is done for you. I'll have a think about this.
Plus auto-scaling the points when zooming might be a future consideration.
Anyways, I really love this contribution. It's super cool! 💯 🍻
@all-contributors please add @tkoyama010 for code, data, example, ideas |
I've put up a pull request to add @tkoyama010! 🎉 |
@allcontributors |
@allcontributors |
@allcontributors |
@tkoyama010 already contributed before to eventOrganizing |
I've put up a pull request to add @bjlittle! 🎉 I've put up a pull request to add @tkoyama010! 🎉 |
@allcontributors |
I've updated the pull request to add @bjlittle! 🎉 |
Oh. You are good. |
🚀 Pull Request
See #373
Description
Add an earthquake sample. This is not perfect (We need to express the scalar by the color of size) but good to go.