Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporary pin uber/h3-py to avoid 4.x breaking behaviour #1157

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

bjlittle
Copy link
Owner

@bjlittle bjlittle commented Oct 16, 2024

🚀 Pull Request

Description

This pull-requeste introduces a temporary pin to h3-py ==3.7.7 in order to avoid breaking behaviour introduced in 4.1.0.

Weirdly they appear to have skipped the 4.0.0 release 😕

Merging this pin to main will unblock the pyvista integration workflow. We can then fix and patch geovista (introducing a minimum pin) to work with h3-py >=4.x

Note that, this breaking behaviour only appears to happen with PyPI dependencies, which install 4.x, whereas the conda lock files don't resolve for 4.x and instead remain with the working 3.7.7.

Hence why the ci-locks-test workflow didn't trip 😠


@github-actions github-actions bot added the type: dependencies Auto-labelled label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.28%. Comparing base (c6519b3) to head (8006630).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1157   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          58       58           
  Lines        2939     2939           
=======================================
  Hits         2683     2683           
  Misses        256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjlittle bjlittle enabled auto-merge (squash) October 16, 2024 21:24
@bjlittle bjlittle merged commit 73fb4a5 into main Oct 16, 2024
21 checks passed
@bjlittle bjlittle deleted the pin-h3 branch October 16, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies Auto-labelled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant