Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Winds sample data #37

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Winds sample data #37

merged 1 commit into from
Jan 30, 2024

Conversation

pp-mo
Copy link
Collaborator

@pp-mo pp-mo commented Jan 30, 2024

@pp-mo pp-mo requested a review from bjlittle as a code owner January 30, 2024 15:39
@pp-mo pp-mo marked this pull request as draft January 30, 2024 15:39
@pp-mo
Copy link
Collaborator Author

pp-mo commented Jan 30, 2024

WIP do not merge

First, I'll just check that this data will work via pooch + gv.pantry
...

@pp-mo pp-mo marked this pull request as ready for review January 30, 2024 16:11
@pp-mo
Copy link
Collaborator Author

pp-mo commented Jan 30, 2024

Ok, I checked it !
Should now work.

@pp-mo
Copy link
Collaborator Author

pp-mo commented Jan 30, 2024

@bjlittle ping!
I think this is the right data.
Please let me know if we need more than just adding this 1 file ?

@pp-mo pp-mo mentioned this pull request Jan 30, 2024
Draft
6 tasks
@bjlittle
Copy link
Owner

bjlittle commented Jan 30, 2024 •
edited
Loading

@pp-mo Do you need both timesteps in the data?

If it doesn't add much value, then we could half the payload by reducing it to 1 timestep.

@bjlittle bjlittle self-assigned this Jan 30, 2024
bjlittle
bjlittle approved these changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pp-mo Awesome, looks good to me 👍

@bjlittle bjlittle merged commit 23c0749 into main Jan 30, 2024
1 check passed
@bjlittle bjlittle deleted the lfric_3dwinds branch January 30, 2024 17:07
@pp-mo
Copy link
Collaborator Author

pp-mo commented Jan 30, 2024 •
edited
Loading

@pp-mo Do you need both timesteps in the data?

I don't really, nor the 4-5 vertical levels.
But the file is already quite small + the dims at least match the structure of the original.
Plus it may prove handy to have some more dims in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlittle bjlittle bjlittle approved these changes

Assignees

@bjlittle bjlittle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pp-mo @bjlittle