Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add item_id if it is missing #257

Merged
merged 2 commits into from
Apr 28, 2024
Merged

add item_id if it is missing #257

merged 2 commits into from
Apr 28, 2024

Conversation

yudonglin
Copy link
Contributor

@yudonglin yudonglin commented Apr 27, 2024

fix #256 #244
fix compatibility with uigf 2.2 and prior

@yudonglin yudonglin marked this pull request as draft April 27, 2024 05:33
fix compatibility with uigf 2.2 and prior
@yudonglin yudonglin marked this pull request as ready for review April 27, 2024 05:40
@yudonglin
Copy link
Contributor Author

yudonglin commented Apr 27, 2024

Side notes:
我的修复措施是在读取时直接填入正确的item_id,但我觉得也可以留空,以改进读取时间和因为要从云端获取id字典导致错误的概率。然而,我有点担心这样做有可能会埋下隐患,并可能在未来的开发过程中导致意想不到的bug。

@biuuu
Copy link
Owner

biuuu commented Apr 27, 2024

我也觉得留空好一些

@yudonglin yudonglin changed the title add item_id according to name if it is missing add item_id if it is missing Apr 27, 2024
@yudonglin
Copy link
Contributor Author

我也觉得留空好一些

好的,已经修改,请帮忙确认并测试一下

@biuuu biuuu merged commit 5ee1cea into biuuu:main Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json 导入失败
2 participants