Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ENV var changes for new platform #3036

Merged
merged 1 commit into from
Aug 14, 2024
Merged

chore: ENV var changes for new platform #3036

merged 1 commit into from
Aug 14, 2024

Conversation

matthewford
Copy link
Contributor

@matthewford matthewford commented Aug 13, 2024

📝 A short description of the changes

  • Allowing the app to pickup and use new ENV variables for backing services on the new platform.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):


For the migration to the DBT platform use new env vars if present:
REDIS_ENDPOINT
DATABASE_CREDENTIALS
@matthewford matthewford marked this pull request as ready for review August 13, 2024 14:59
@matthewford matthewford changed the title Preparing ENV var changes for new platform chore: reparing ENV var changes for new platform Aug 13, 2024
@matthewford matthewford changed the title chore: reparing ENV var changes for new platform chore: ENV var changes for new platform Aug 13, 2024
@dreamfall dreamfall merged commit e8a4342 into main Aug 14, 2024
11 checks passed
@dreamfall dreamfall deleted the env-var-changes branch August 14, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants