Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all years for admin search when no params #3023

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

TheDancingClown
Copy link
Contributor

Signed-off-by: Louis Kirkham [email protected]

📝 A short description of the changes

Fixes year being switched to current year when admins enter search terms and submit.

  • Changes selected year to "all_years" for admin search default
  • params[:year] is being assigned twice due to the non-javascript year select. This PR select is removed so the param is only passed once.
  • Changed :award_year param to :year

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

Signed-off-by: Louis Kirkham <[email protected]>

Changes selected year to all for admin search default
Clears up params to use :year
@TheDancingClown TheDancingClown merged commit 00be040 into main Aug 1, 2024
11 of 12 checks passed
@TheDancingClown TheDancingClown deleted the search-year branch August 1, 2024 12:57
This was referenced Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants