Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change award year switch to submit form on change #2993

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

TheDancingClown
Copy link
Contributor

@TheDancingClown TheDancingClown commented Jul 3, 2024

πŸ“ A short description of the changes

  • Change selector for the search query as admin and assessor have different classes but the ID 'new_search' is present in both.
  • Use javascript to set the select option and submit the form when switching the award year.
  • Remove hidden year tags which caused params to be set twice.
  • Removes award years after the current year.
  • Adds support for no js

πŸ”— Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

βœ… Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

@TheDancingClown TheDancingClown changed the title Bug fixes on application award year filter Change award year switch to submit form on change Jul 4, 2024
@TheDancingClown TheDancingClown merged commit 4960b38 into main Jul 4, 2024
11 checks passed
@TheDancingClown TheDancingClown deleted the year-filter-qa-2 branch July 4, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants