Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds radio buttons to switch the award year #2988

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

TheDancingClown
Copy link
Contributor

@TheDancingClown TheDancingClown commented Jul 2, 2024

📝 A short description of the changes

  • Adds 3 new radio buttons to change the award year on admin/form_answers#index - 'Current year', 'All years' and 'Other'.
  • Clicking 'Other' shows the existing years dropdown.
  • Selecting 'Current Year' or 'All years' gets the form_answers#index passing the year param by using the data-url set in the view.
  • On admin, all years are selected as default, but on assessors current year is default.
  • Adds help copy to the search bar and changes the search icon to white on grey background.

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

  • None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

Screenshot 2024-07-02 at 11 43 08 Screenshot 2024-07-02 at 11 43 29

@TheDancingClown TheDancingClown marked this pull request as draft July 2, 2024 10:44
@TheDancingClown TheDancingClown marked this pull request as ready for review July 2, 2024 10:56
Copy link
Contributor

@Lubosky Lubosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments related to small tweaks but otherwise good 👍

@TheDancingClown TheDancingClown merged commit 0766c0c into main Jul 2, 2024
10 of 11 checks passed
@TheDancingClown TheDancingClown deleted the applications-filter branch July 2, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants