Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject blank & null vallues when generating PDF styles #2983

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented Jun 25, 2024

📝 A short description of the changes

Reject blank & nil values from being picked by PDF generator.

🔗 Link to the relevant story (or stories)

Asana card here: https://app.asana.com/0/1200504523179343/1207645684540462/f
AppSignal error here: https://appsignal.com/bit-zesty/sites/601bfb8714ad665fb298effe/exceptions/incidents/3606/samples/601bfb8714ad665fb298effe-664236946902935182917192454001

:shipit: Deployment implications

Done

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@Lubosky Lubosky merged commit 5a974f9 into main Jun 25, 2024
11 checks passed
@Lubosky Lubosky deleted the pdf-form-error branch June 25, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants