Error fixes #2968
Merged
Error fixes #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniBitZesty
force-pushed
the
tweak-sidebar-steps
branch
from
70258f0
to
54e6cbb
Compare
dreamfall
reviewed
Jun 19, 2024
| @@ -190,7 +190,7 @@ window.FormValidation = | |||
|
|
|||
| addSubfieldError: (question, subquestion) -> | |||
| questionRef = question.attr("data-question_ref") | |||
| input = $(subquestion).find('input,textarea,select').filter(':visible') | |||
| input = $(subquestion).find('input,textarea,select') | |||
There was a problem hiding this comment.
I'm actually not sure about this, cause this somehow might impact some weird conditional questions if we have a question where the subfield is hidden 🤔
dreamfall
approved these changes
Jun 19, 2024
…rs not appearing on subfields on first render
DaniBitZesty
force-pushed
the
tweak-sidebar-steps
branch
from
54e6cbb
to
2224984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 A short description of the changes
Corrects how 'step-errors' class is removed from side panel links to form sections, it was previously excluding links two-levels below elements with 'steps-progress-bar' class, so section C.1, C.2, C.3 links weren't targeted and the error icon persisted even after errors had been corrected
Fixes missing errors for incomplete subfields on the initial render of the form. Previously, validation errors for hidden subfields were not displayed when navigating via the side panel links or the error summary links. These errors only became visible after navigating to another form section and then returning, this was because of
.filter(:visible), which excluded hidden elements from the validation process.🔗 Link to the relevant story (or stories)
✅ Checklist
🖼️ Screenshots (if appropriate - no PII/Prod data):