Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] fix financial year presence validation for PO & SD applications #2475

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

dreamfall
Copy link
Contributor

📝 A short description of the changes

  • add classes required for validateDateByYears to function properly. probably got broken in the beginning of the award year with the changes to other award types

🔗 Link to the relevant story (or stories)

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

image

@dreamfall dreamfall merged commit 9b39589 into staging Aug 8, 2023
5 of 6 checks passed
@dreamfall dreamfall deleted the production-hotfix-0808 branch August 8, 2023 12:37
@dreamfall dreamfall restored the production-hotfix-0808 branch August 8, 2023 12:38
@dreamfall dreamfall deleted the production-hotfix-0808 branch August 8, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants