Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds non-js validation for matrix cells #2474

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Conversation

DaniBitZesty
Copy link
Contributor

@DaniBitZesty DaniBitZesty commented Aug 8, 2023

📝 A short description of the changes

  • Adds required field below empty cells when submitting a form with JS-disabled
  • Disables autocalculated cells
  • Autocalculates row totals, column totals, subtotals and proportions without using JS

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@DaniBitZesty DaniBitZesty deleted the matrix-cell-errors branch August 8, 2023 10:25
@DaniBitZesty DaniBitZesty restored the matrix-cell-errors branch August 8, 2023 10:46
@DaniBitZesty DaniBitZesty reopened this Aug 8, 2023
@DaniBitZesty DaniBitZesty force-pushed the matrix-cell-errors branch 3 times, most recently from 047d846 to e2e4d30 Compare August 14, 2023 08:14
@DaniBitZesty DaniBitZesty merged commit 2f6f7a5 into main Aug 14, 2023
7 checks passed
@DaniBitZesty DaniBitZesty deleted the matrix-cell-errors branch August 14, 2023 08:57
@DaniBitZesty DaniBitZesty mentioned this pull request Aug 15, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants