Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PO / SD upload rework (after QA) #2420

Merged
merged 3 commits into from
Jul 17, 2023
Merged

PO / SD upload rework (after QA) #2420

merged 3 commits into from
Jul 17, 2023

Conversation

Lubosky
Copy link
Contributor

@Lubosky Lubosky commented Jul 17, 2023

📝 A short description of the changes

Fixes to the issues found during the QA

  • fixed missing translations
  • fixed missing event not being logged
  • fixed error related to incorrect method name
  • added spacing to section bar elements

🔗 Link to the relevant story (or stories)

Asana card here: https://app.asana.com/0/1200504523179345/1203129837638856/f

:shipit: Deployment implications

None

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@Lubosky Lubosky merged commit c1a5a37 into main Jul 17, 2023
8 checks passed
@Lubosky Lubosky deleted the po-sd-upload-rework-qa branch July 17, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants