-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds unique ids across appraisal view #2408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e for comment textareas
DaniBitZesty
force-pushed
the
accessibility-tweaks
branch
from
July 11, 2023 13:25
4553f9a
to
1f43626
Compare
TheDancingClown
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 A short description of the changes
Mostly changes to add unique ids to elements in the appraisal page
Also corrects a bug where list elements were not correctly wrapped in
<li>
tagsRemoves tab roles from collapsable components on Settings/Users/Appraisals pages to address nested interactive elements issue
🔗 Link to the relevant story (or stories)
Deployment implications
✅ Checklist
🖼️ Screenshots (if appropriate - no PII/Prod data):