Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds unique ids across appraisal view #2408

Merged
merged 19 commits into from
Jul 11, 2023
Merged

Adds unique ids across appraisal view #2408

merged 19 commits into from
Jul 11, 2023

Conversation

DaniBitZesty
Copy link
Contributor

@DaniBitZesty DaniBitZesty commented Jul 10, 2023

📝 A short description of the changes

  • Mostly changes to add unique ids to elements in the appraisal page

  • Also corrects a bug where list elements were not correctly wrapped in <li> tags

  • Removes tab roles from collapsable components on Settings/Users/Appraisals pages to address nested interactive elements issue

🔗 Link to the relevant story (or stories)

:shipit: Deployment implications

✅ Checklist

  • Features that cannot go live are behind a feature flag/env var or specify deploy date and open PR as draft
  • I have checked that commit messages make sense and explain the reasoning for each change
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have squashed any unnecessary or part-finished commits

🖼️ Screenshots (if appropriate - no PII/Prod data):

@DaniBitZesty DaniBitZesty merged commit 7af4e37 into main Jul 11, 2023
7 checks passed
@DaniBitZesty DaniBitZesty deleted the accessibility-tweaks branch July 11, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants