Skip to content

[PM-4128] Remove nullability of Send.Data and Send.Keys #7266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harr1424 wants to merge 2 commits into
base: main
Choose a base branch
from
+10,955 −12
Open

[PM-4128] Remove nullability of Send.Data and Send.Keys #7266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c18ca53
Send.Key and Send.Data NOT NULL
harr1424 Mar 20, 2026
68d26f0
backfill EF providers with empty strings for NULL Data or Key values
harr1424 Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/Core/Tools/Entities/Send.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,22 +46,12 @@ public class Send : ITableObject<Guid>
/// <summary>
/// Stores data containing or pointing to the transmitted secret. JSON.
/// </summary>
/// <note>
/// Must be nullable due to several database column configuration.
/// The application and all other databases assume this is not nullable.
/// Tech debt ticket: PM-4128
/// </note>
public string? Data { get; set; }
public string Data { get; set; } = string.Empty;

/// <summary>
/// Stores the data's encryption key. Encrypted.
/// </summary>
/// <note>
/// Must be nullable due to MySql database column configuration.
/// The application and all other databases assume this is not nullable.
/// Tech debt ticket: PM-4128
/// </note>
public string? Key { get; set; }
public string Key { get; set; } = string.Empty;

/// <summary>
/// Password provided by the user. Protected with pbkdf2.
Expand Down
Loading
Loading