[PM-33215] Revert MasterPasswordPolicyRequirement implementation#7232
Open
[PM-33215] Revert MasterPasswordPolicyRequirement implementation#7232
Conversation
This was being used to combine policies before sending them to the client. Instead, the server just send the policies and the client should process/combine them. Revert this to save unnecessary QA (etc) and we will refactor this away in the future.
eliykat
changed the title
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7232 +/- ##
==========================================
- Coverage 57.53% 57.51% -0.03%
==========================================
Files 2032 2031 -1
Lines 89486 89507 +21
Branches 7957 7958 +1
==========================================
- Hits 51487 51479 -8
- Misses 36154 36187 +33
+ Partials 1845 1841 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JimmyVo16
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-33215
📔 Objective
Revert the
MasterPasswordPolicyRequirementimplementation. This code will be removed, so there is no need to transition to the new implementation. (Although I did add unit tests in the meantime - maybe unnecessary - but while we have it it's worth having tests around it.)Context: this was being used to combine MP policies before sending them to the client for enforcement. However, we expect to have signed policies in the not-too-distant future, which will require the original policy object to be sent to the client for verification before being combined. Further, the client already has similar code, so this is just duplicating the client implementation. In the future this endpoint will just serve the policy objects without any preprocessing.
📸 Screenshots