Skip to content

[PM-21926] Add salt to Admin Console DTOs#7231

Draft
ike-kottlowski wants to merge 3 commits intomainfrom
auth/pm-21926/add-salt-to-ac-dtos
Draft

[PM-21926] Add salt to Admin Console DTOs#7231
ike-kottlowski wants to merge 3 commits intomainfrom
auth/pm-21926/add-salt-to-ac-dtos

Conversation

@ike-kottlowski
Copy link
Contributor

@ike-kottlowski ike-kottlowski commented Mar 16, 2026

🎟️ Tracking

PM-21926

This PR depends on:
#7230

📔 Objective

Add MasterPasswordSalt to DTOs that are owned by Admin Console.

@ike-kottlowski ike-kottlowski added the ai-review Request a Claude code review label Mar 16, 2026
@claude
Copy link
Contributor

claude bot commented Mar 16, 2026

Claude finished @ike-kottlowski's task in 1m 22s —— View job


Overall Assessment: APPROVE

Reviewed 4 changed files adding MasterPasswordSalt to two Admin Console DTOs (OrganizationUserResetPasswordDetails and OrganizationUserResetPasswordDetailsResponseModel). The property is correctly sourced from User.MasterPasswordSalt, follows existing patterns for KDF parameter exposure, and is covered by both unit and integration tests. No findings.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details7044e9d7-40d9-4e8e-8bdc-fa271ce280c4


Fixed Issues (2) Great job! The following issues were fixed in this Pull Request
Severity Issue Source File / Package
MEDIUM CSRF /src/Api/KeyManagement/Controllers/AccountsKeyManagementController.cs: 202
MEDIUM Use_Of_Hardcoded_Password /src/Core/Constants.cs: 165

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.53%. Comparing base (8d9ace6) to head (603d59c).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7231      +/-   ##
==========================================
+ Coverage   56.88%   57.53%   +0.65%     
==========================================
  Files        2028     2032       +4     
  Lines       88826    89490     +664     
  Branches     7918     7957      +39     
==========================================
+ Hits        50528    51492     +964     
+ Misses      36468    36153     -315     
- Partials     1830     1845      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant