Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BRE-101] Remove dept-devops from CODEOWNERS #826

Merged
merged 8 commits into from
Oct 17, 2024
Merged

[BRE-101] Remove dept-devops from CODEOWNERS #826

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ea85d75
BRE-101: Remove dept-devops from CODEOWNERS
michalchecinski Jun 7, 2024
b60a0a6
Fix
michalchecinski Jun 10, 2024
82bd6a6
Merge branch 'main' into BRE-101-Remove-dept-devops-from-CODEOWNERS
michalchecinski Oct 14, 2024
986a2ae
Change codeowners
michalchecinski Oct 15, 2024
23090e5
Update .github/CODEOWNERS
michalchecinski Oct 15, 2024
03c042e
Fix
michalchecinski Oct 15, 2024
fed0b69
Update .github/CODEOWNERS
michalchecinski Oct 17, 2024
93e0331
Fix
michalchecinski Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 44 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,45 @@
#
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

# BRE for publish workflow changes
.github/workflows/publish-*.yml @bitwarden/dept-bre

# Shared workflows ownership

## BRE & SM teams shared ownership
.github/workflows/build-cli-docker.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-cli.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-cpp.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-dotnet.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-go.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-java.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-python-wheels.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/build-rust-crates.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is listed in the ## Multiple owners section below as well. Could you delete one of the entries?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Removed it from here, as this workflow is not only owned by SM dev.

.github/workflows/release-bws.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-cpp.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-dotnet.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-go.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-java.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-napi.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-python.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev
.github/workflows/release-ruby.yml @bitwarden/dept-bre @bitwarden/team-secrets-manager-dev

## Multiple owners
.github/workflows/build-android.yml
.github/workflows/build-rust-crates.yml
.github/workflows/build-rust-cross-platform.yml
.github/workflows/build-swift.yml
.github/workflows/build-wasm-internal.yml
.github/workflows/build-wasm.yml
.github/workflows/release-rust-crates.yml
.github/workflows/release-swift.yml
.github/workflows/release-wasm.yml

michalchecinski marked this conversation as resolved.
Show resolved Hide resolved
.github/workflows/version-bump.yml


# DevOps for Actions and other workflow changes.
.github/workflows @bitwarden/dept-devops

# Secrets Manager team
crates/bitwarden-sm @bitwarden/team-secrets-manager-dev
Expand All @@ -16,3 +52,9 @@ crates/bws @bitwarden/team-secrets-manager-dev
crates/bws/Cargo.toml
crates/bws/scripts/install.ps1
crates/bws/scripts/install.sh

## Docker files have shared ownership ##
**/Dockerfile
**/*.Dockerfile
**/.dockerignore
**/entrypoint.sh
Loading