Skip to content

Conversation

tangowithfoxtrot
Copy link
Contributor

@tangowithfoxtrot tangowithfoxtrot commented Sep 3, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/SM-1565

📔 Objective

goto-bus-stop/setup-zig is no longer maintained. Switch to using mlugg/setup-zig, which is a maintained Action.

Also, update to latest stable Zig.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@tangowithfoxtrot tangowithfoxtrot requested a review from a team as a code owner September 3, 2025 15:11
Copy link

sonarqubecloud bot commented Sep 3, 2025

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.30%. Comparing base (902c133) to head (bce95c3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1307   +/-   ##
=====================================
  Coverage   7.30%   7.30%           
=====================================
  Files         20      20           
  Lines       1383    1383           
=====================================
  Hits         101     101           
  Misses      1282    1282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Sep 3, 2025

Logo
Checkmarx One – Scan Summary & Detailsa54dfad8-a29e-4825-8867-9986fb2a0579

Great job! No new security vulnerabilities introduced in this pull request

Copy link
Contributor

@cd-bitwarden cd-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tangowithfoxtrot tangowithfoxtrot merged commit 7b4515a into main Sep 4, 2025
88 of 93 checks passed
@tangowithfoxtrot tangowithfoxtrot deleted the SM-1565-replace-unmaintained-goto-bus-stop-setup-zig-action-in-secrets-manager-workflows branch September 4, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants