[PM-8618] Credential Exchange #32
Conversation
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
- Coverage 63.43% 63.34% -0.09%
==========================================
Files 187 189 +2
Lines 12999 13618 +619
==========================================
+ Hits 8246 8627 +381
- Misses 4753 4991 +238 ☔ View full report in Codecov by Sentry. |
| impl TryFrom<CipherView> for crate::Cipher { | ||
| type Error = MissingFieldError; | ||
| impl crate::Cipher { | ||
| pub(crate) fn from_cipher( |
There was a problem hiding this comment.
This is really unfriendly. And we should figure out a better strategy for handling this.
@dani-garcia Long term we've discussed wanting dedicated DTOs for ciphers. Should we go ahead with it and create a CreateCipherView dto in vault which lets you have a full passkey unencrypted?
An alternative would be to add a method to Cipher letting you pass in the new passkey and we can avoid the dance of export needing to know how to encrypt things.
FYI @coroiu
There was a problem hiding this comment.
Personal reminder. Json currently does not support passkey exports, web clients do.
…ial-exchange # Conflicts: # Cargo.lock
Hinton
force-pushed
the
credential-exchange
branch
from
dfe65e7
to
95c6f87
Compare
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8618
📔 Objective
Initial implementation of the Credential Exchange Format. Currently supports the following types:
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes