Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Fido2VerificationException details to user #763

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jonashendrickx
Copy link
Member

Description

Some requests are failing with a HTTP Status Code 500. We need to return these exceptions to the user/customer, so they can address any mistakes during development if applicable.

Fido2NetLib.Fido2VerificationException: Authenticator response challenge does not match original challenge
   
at Fido2NetLib.AuthenticatorResponse.BaseVerify(IReadOnlySet`1 fullyQualifiedExpectedOrigins, ReadOnlySpan`1 originalChallenge)
   
at Fido2NetLib.AuthenticatorAssertionResponse.VerifyAsync(AssertionOptions options, Fido2Configuration config, Byte[] storedPublicKey, IReadOnlyList`1 storedDevicePublicKeys, UInt32 storedSignatureCounter, IsUserHandleOwnerOfCredentialIdAsync isUserHandleOwnerOfCredId, IMetadataService metadataService, CancellationToken cancellationToken)
   
at Fido2NetLib.Fido2.MakeAssertionAsync(AuthenticatorAssertionRawResponse assertionResponse, AssertionOptions originalOptions, Byte[] storedPublicKey, IReadOnlyList`1 storedDevicePublicKeys, UInt32 storedSignatureCounter, IsUserHandleOwnerOfCredentialIdAsync isUserHandleOwnerOfCredentialIdCallback, CancellationToken cancellationToken)
   
at Passwordless.Service.Fido2Service.SignInCompleteAsync(SignInCompleteDTO request, String device, String country) in /home/runner/work/passwordless-server/passwordless-server/src/Service/Fido2Service.cs:line 386
   
at Passwordless.Api.Endpoints.SigninEndpoints.CompleteAsync(SignInCompleteDTO payload, HttpRequest request, IFido2Service fido2Service) in /home/runner/work/passwordless-server/passwordless-server/src/Api/Endpoints/Signin.cs:line 91

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner November 13, 2024 20:04
@jonashendrickx jonashendrickx merged commit 3fe5d8d into main Nov 14, 2024
16 checks passed
@jonashendrickx jonashendrickx deleted the signin_complete_exception branch November 14, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants