Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-434 | update secret api key wording when you download them #582

Merged
merged 1 commit into from
May 13, 2024

Conversation

merissaacosta
Copy link
Contributor

@merissaacosta merissaacosta commented May 10, 2024

Ticket

Description

Continuation of https://github.com/bitwarden/passwordless-server/pull/580/files
QA thought we should also update the wording when you download the keys

Screenshots

Screenshot 2024-05-10 at 9 23 09 AM

@merissaacosta merissaacosta self-assigned this May 10, 2024
@merissaacosta merissaacosta requested a review from a team as a code owner May 10, 2024 14:24
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 32.58%. Comparing base (1146ccc) to head (905eedc).

Files Patch % Lines
src/AdminConsole/Endpoints/ApplicationEndpoints.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #582   +/-   ##
=======================================
  Coverage   32.58%   32.58%           
=======================================
  Files         525      525           
  Lines       26562    26562           
  Branches      862      862           
=======================================
  Hits         8655     8655           
  Misses      17786    17786           
  Partials      121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx jonashendrickx merged commit 309e89b into main May 13, 2024
15 checks passed
@jonashendrickx jonashendrickx deleted the PAS-434/update-api-keys-download branch May 13, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants