Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAS-531 | Generate Facet ID for Android #70

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Jul 5, 2024

Ticket

Description

We can skip a significant amount of complexity to use the Android SDK, by calculating the Facet ID and injecting it as the origin for registering and signing in.

We can essentially get rid of the Facet ID section in the documentation, and simplify the PasswordlessOptions.

data class PasswordlessOptions(
// Your public API key
val apiKey: String,

// Identifier for your server, for example 'example.com' if your backend is hosted at https://example.com.
val rpId: String,

// This is where your Facet ID goes
val origin: String,

// Where your backend is hosted
val backendUrl:String,

// Passwordless.dev server, change for self-hosting
val apiUrl: String = "https://v4.passwordless.dev"
)

To other section which can be removed after merging this PR:

image

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • Verified to be working.

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner July 5, 2024 12:31
@jonashendrickx jonashendrickx changed the title PAS-531 | Generate Facet Id for android PAS-531 | Generate Facet ID for Android Jul 5, 2024
@jonashendrickx jonashendrickx merged commit 8654f16 into main Jul 8, 2024
4 checks passed
@jonashendrickx jonashendrickx deleted the PAS-531-Generate-Facet-ID-for-Android branch July 8, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants