Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEEEP: Refactor navigation of unauthenticated and authenticated state. #68

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Jun 28, 2024

Description

Refactors the navigation between authenticated and unauthenticated state. Previously what was happening was that after logging in you're redirected to the CredentialsFragment, but when you press the back button, you're navigating back to the login screen, however, you're actually logged in, so you shouldn't be seeing this activity. Instead what we want is to close the app for convenience to avoid confusion.

Unauthenticated and authenticated sessions have therefore now their own navigation graphs. And it doesn't involve any ugly hacks that require to clear the navigation history stack.

Shape

n/a

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner June 28, 2024 12:04
@jonashendrickx jonashendrickx changed the title Refactor navigation of unauthenticated and authenticated state. BEEEP: Refactor navigation of unauthenticated and authenticated state. Jun 28, 2024
@jonashendrickx jonashendrickx enabled auto-merge (squash) June 28, 2024 12:25
@jonashendrickx jonashendrickx merged commit 762e8a6 into main Jun 28, 2024
4 checks passed
@jonashendrickx jonashendrickx deleted the android-refactor-navigation branch June 28, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants