Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-8222] Cherrypick - New device verification page fixes (#1381) #1384

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

andrebispo5
Copy link
Contributor

(cherry picked from commit e29448f)

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8222

📔 Objective

Cherrypick remaining fixes from main into rc branch.
#1381

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details1d41cd78-9678-4faf-8555-933d4ae8ad2a

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.67%. Comparing base (b3fa624) to head (b258ffb).
Report is 1 commits behind head on release/2025.02-rc6.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           release/2025.02-rc6    #1384      +/-   ##
=======================================================
- Coverage                89.67%   89.67%   -0.01%     
=======================================================
  Files                      765      765              
  Lines                    48032    48040       +8     
=======================================================
+ Hits                     43074    43081       +7     
- Misses                    4958     4959       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrebispo5 andrebispo5 merged commit e460cdd into release/2025.02-rc6 Feb 25, 2025
8 checks passed
@andrebispo5 andrebispo5 deleted the pm-8222/cp-new-device-fixes branch February 25, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants