Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-18244: Fix close button ui bug on ViewItem screen #1382

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ezimet-livefront
Copy link
Collaborator

@ezimet-livefront ezimet-livefront commented Feb 25, 2025

🎟️ Tracking

PM-18244

📔 Objective

📸 Screenshots

The bug was like this:

6w3rmb.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Logo
Checkmarx One – Scan Summary & Details879bd154-34f7-4f2c-8b1d-905008923c4c

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.66%. Comparing base (ca78f61) to head (9c45b70).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1382   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         765      765           
  Lines       48014    48029   +15     
=======================================
+ Hits        43052    43066   +14     
- Misses       4962     4963    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 95 to 97
.onAppear {
Task {
await store.perform(.appeared)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I don't love this pattern, since we lose out on cancellation if the view disappears before the task completes. In this case, we aren't making any network requests, so it's probably not a big deal, but I think it'd be helpful to add a comment for why we are using this pattern here and what it fixes (including affected OS versions if known).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] The Close text link on the View Item panel is constantly shifting position
2 participants