PM-14632: Revert to legacy create account flow if updated environment doesn't support email verification #1161
Conversation
… doesn't support email verification
matt-livefront
requested review from
fedemkr,
ezimet-livefront and
KatherineInCode
matt-livefront
requested review from
phil-livefront,
brant-livefront and
a team
as code owners
|
Fixed Issues
|
| if await !services.configService.getFeatureFlag( | ||
| .emailVerification, | ||
| defaultValue: false, | ||
| forceRefresh: true, | ||
| isPreAuth: true | ||
| ) { | ||
| // If email verification isn't enabled in the selected environment, switch to the | ||
| // legacy create account flow. | ||
| delegate?.switchToLegacyCreateAccountFlow() | ||
| } |
There was a problem hiding this comment.
🤔 How does this behave on really slow internet connection scenarios?
There was a problem hiding this comment.
It won't switch you back to the legacy flow until the request completes, but it doesn't block the UI or anything. Hopefully this is just a temporary change until the legacy flow is removed.
There was a problem hiding this comment.
And does this flow get cancelled if the user goes to another screen (back or forwards) while the request is in progress? Or after the request completes in another screen the user will be redirected? Again in slow connection scenarios.
There was a problem hiding this comment.
No, not until the request times out at least. I added a check to only notify the delegate if the view is still visible.
matt-livefront
deleted the
matt/PM-14632-email-verification-change-env
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1161 +/- ##
==========================================
+ Coverage 89.38% 89.39% +0.01%
==========================================
Files 688 688
Lines 43741 43769 +28
==========================================
+ Hits 39098 39129 +31
+ Misses 4643 4640 -3 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
PM-14632
📔 Objective
From the create account screen in the email verification flow, if you change the environment to an environment that doesn't support email verification, attempting to create an account will fail because the environment doesn't have the updated endpoints. This changes that to switch back to the legacy create account flow.
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-22.at.11.40.04.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes