PM-14632: Revert to legacy create account flow if updated environment doesn't support email verification #1161
+87
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… doesn't support email verification
matt-livefront
requested review from
fedemkr,
ezimet-livefront and
KatherineInCode
matt-livefront
requested review from
phil-livefront,
brant-livefront and
a team
as code owners
|
No New Or Fixed Issues Found |
fedemkr
reviewed
Nov 25, 2024
Comment on lines
+238
to
+247
| if await !services.configService.getFeatureFlag( | ||
| .emailVerification, | ||
| defaultValue: false, | ||
| forceRefresh: true, | ||
| isPreAuth: true | ||
| ) { | ||
| // If email verification isn't enabled in the selected environment, switch to the | ||
| // legacy create account flow. | ||
| delegate?.switchToLegacyCreateAccountFlow() | ||
| } |
There was a problem hiding this comment.
🤔 How does this behave on really slow internet connection scenarios?
There was a problem hiding this comment.
It won't switch you back to the legacy flow until the request completes, but it doesn't block the UI or anything. Hopefully this is just a temporary change until the legacy flow is removed.
There was a problem hiding this comment.
And does this flow get cancelled if the user goes to another screen (back or forwards) while the request is in progress? Or after the request completes in another screen the user will be redirected? Again in slow connection scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14632
📔 Objective
From the create account screen in the email verification flow, if you change the environment to an environment that doesn't support email verification, attempting to create an account will fail because the environment doesn't have the updated endpoints. This changes that to switch back to the legacy create account flow.
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-22.at.11.40.04.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes