-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-14425] [BEEEP] Add test plans #1106
base: main
Are you sure you want to change the base?
Conversation
…ck in BitwardenTestCase for skip simulator checking.
… unit test plans so they are empty on remote and only generated locally each time if needed.
No New Or Fixed Issues Found |
Co-authored-by: Katherine Bertelsen <[email protected]>
TEST_PLAN_SNAPSHOT_PATH="TestPlans/TestPlan-Snapshot.xctestplan" | ||
SNAPSHOT_TESTS_TARGET="BitwardenSharedTests" | ||
|
||
mint install atakankarsli/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've decided not to include the installation of xctestplanner
in the Mintfile so it's only installed when actually being used. For now this script won't be called in CI/CD so there's no need to waste time installing xctestplanner
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool!
A few questions from me:
- I'm seeing a few date/time failures in the tests. It looks like we previously set
TZ=UTC
as an environment variable. Could you add that to the test plans? - We used to have a splash screen that showed while testing. That relies on a
-testing
argument passed on launch, could you add that? - Should your comment for
git update-index --skip-worktree TestPlans/TestPlan-Snapshot.xctestplan TestPlans/TestPlan-Unit.xctestplan
be documented in the README?
Previous test settings:
It looks like the test plans don't include the Networking target, could you include that? I think that's why the test counts are different.
🎟️ Tracking
PM-14425
📔 Objective
Add test plans so we can separate unit vs snapshot tests vs all tests.
Note:
Before the
generate_test_plans.sh
is used, make sure to run the next command on the root folder so the changes in the test plans are not tracked by git so the test plans changes remain locally. Therefore there is less possibility of merge conflicts and there's no need to keep the files updated remotely as they can be automatically generated.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes