Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13902] Update Bitwarden SDK for new SSH Key type #1090

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

fedemkr
Copy link
Member

@fedemkr fedemkr commented Oct 29, 2024

🎟️ Tracking

PM-13902

📔 Objective

Update Bitwarden SDK to unstable branch and revision f66f5546dcfe70480e4783367b119cfbc5d0268f to have:

Note: this doesn't finish the work for the new SSH Key type, just updates the code so it doesn't break by updating to this Bitwarden SDK version. The SSH Key work will be continued in PM-10401

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@fedemkr fedemkr linked an issue Oct 29, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.56%. Comparing base (17ae8bc) to head (f2fd343).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   89.53%   89.56%   +0.03%     
==========================================
  Files         677      677              
  Lines       42730    42805      +75     
==========================================
+ Hits        38260    38340      +80     
+ Misses       4470     4465       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedemkr fedemkr merged commit f588bd5 into main Oct 30, 2024
9 checks passed
@fedemkr fedemkr deleted the pm-13902/update-sdk-ssh-key branch October 30, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Steam OTP not working correctly
2 participants