Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add ability to set custom image registry #88

Closed
wants to merge 1 commit into from

Conversation

ClusterJan
Copy link

@ClusterJan ClusterJan commented Dec 15, 2023

Add a global variable to override the image registry to allow the usage of a private registry.

As my changes include a new registry option for the database image, this seems to be a breaking change. But I don't know if this might be obsolete, because of the issue #70.

@ClusterJan ClusterJan requested a review from a team as a code owner December 15, 2023 10:51
@jhbeskow
Copy link
Contributor

@vgrassia, there is a separate PR (#89) that also does something similar here. I will leave it to your discretion on which you prefer. That one is a bit more granular on the registries as you would provide them as part of each image's name.

@vgrassia
Copy link
Member

vgrassia commented Dec 18, 2023

Thank you for bringing this up. We've added the ability to customize each individual image registry with PR #89.

@vgrassia vgrassia closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants