Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-11973] feat: add custom cert option #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheKangaroo
Copy link

Add optional custom certificate from configmap.

I also added an example on how to add the ca certificate via preInstall array.

@TheKangaroo TheKangaroo requested a review from a team as a code owner September 11, 2024 14:28
@TheKangaroo
Copy link
Author

I'm not sure volume is the right key to put the caCertificate key under, since technically caCertificate is not a volume, but a ConfigMap.
WDYT?

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-11973

@bitwarden-bot bitwarden-bot changed the title feat: add custom cert option [PM-11973] feat: add custom cert option Sep 11, 2024
@bitwarden-bot bitwarden-bot added in-product-review Community PR is being reviewed by Bitwarden's Product team community-pr labels Sep 11, 2024
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailsd1dca1e4-db16-4403-a2d4-aaac5a45d06c

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Passwords And Secrets - Generic Password /tests.yml: 103 Query to find passwords and secrets in infrastructure code.
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 96 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 103 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /update-versions.yml: 52 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 39 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /update-versions.yml: 27 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 111 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump.yml: 23 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /update-versions.yml: 131 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
HIGH Passwords And Secrets - Generic Password /tests.yml: 117
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump-self-host.yml: 39
MEDIUM Unpinned Actions Full Length Commit SHA /update-versions-self-host.yml: 131
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump-self-host.yml: 96
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump-self-host.yml: 111
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump-self-host.yml: 23
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump-sm-operator.yml: 47
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump-self-host.yml: 103
MEDIUM Unpinned Actions Full Length Commit SHA /update-versions-self-host.yml: 52
MEDIUM Unpinned Actions Full Length Commit SHA /update-versions-self-host.yml: 27
MEDIUM Unpinned Actions Full Length Commit SHA /version-bump-sm-operator.yml: 30
MEDIUM Unpinned Actions Full Length Commit SHA /tests.yml: 38

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-pr in-product-review Community PR is being reviewed by Bitwarden's Product team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants