-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-11973] feat: add custom cert option #177
Open
TheKangaroo
wants to merge
1
commit into
bitwarden:main
Choose a base branch
from
TheKangaroo:feat/custom-cert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure volume is the right key to put the caCertificate key under, since technically caCertificate is not a volume, but a ConfigMap. |
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
feat: add custom cert option
[PM-11973] feat: add custom cert option
Sep 11, 2024
bitwarden-bot
added
in-product-review
Community PR is being reviewed by Bitwarden's Product team
community-pr
labels
Sep 11, 2024
New Issues
Fixed Issues
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional custom certificate from configmap.
I also added an example on how to add the ca certificate via preInstall array.