Skip to content

Conversation

@BTreston
Copy link
Contributor

@BTreston BTreston commented Oct 3, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25710
https://bitwarden.atlassian.net/browse/PM-25708
https://bitwarden.atlassian.net/browse/PM-25707

📔 Objective

Updates angular to v20. Adds minimatch and glob as explicit dependencies to resolve some persistent issues during major framework updates with these two libraries having various incompatible versions as sub-dependencies.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.67%. Comparing base (06dbc14) to head (b34a8c5).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #892      +/-   ##
=========================================
- Coverage   12.62%   7.67%   -4.95%     
=========================================
  Files          68      68              
  Lines        2757    2776      +19     
  Branches      477     482       +5     
=========================================
- Hits          348     213     -135     
- Misses       2381    2548     +167     
+ Partials       28      15      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Logo
Checkmarx One – Scan Summary & Detailsdd5a22d2-b8fd-47b3-bc00-533813c24cff

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
HIGH CVE-2025-10200 Npm-electron-38.1.0
detailsRecommended version: 38.1.1
Description: Use After Free in 'ServiceWorker' in Google Chrome on Desktop prior to 140.0.7339.127 allowed a remote attacker to potentially exploit heap corrupt...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: 0ITZYScW6a2EnMBNvkMdvvobGHyNOaUYthoRB5EAVJs%3D
Vulnerable Package
HIGH CVE-2025-10502 Npm-electron-38.1.0
detailsDescription: Heap Buffer Overflow in 'ANGLE' in Google Chrome prior to 140.0.7339.185 allowed a remote attacker to potentially exploit heap corruption via malic...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: xbhBtWJEYAjBqRKt2TqGBh5ZXgYeEIPKbTffx7MBw6A%3D
Vulnerable Package
HIGH CVE-2025-10891 Npm-electron-38.1.0
detailsRecommended version: 38.2.0
Description: Integer overflow in V8 in Google Chrome prior to 140.0.7339.207 allowed a remote attacker to potentially exploit heap corruption via a crafted HTML...
Attack Vector: NETWORK
Attack Complexity: LOW

ID: je2TjApcA5%2FShTDbsuvISw8hPVNGhyj8FgJIy3cSys4%3D
Vulnerable Package
Fixed Issues (3)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
LOW CVE-2025-58751 Npm-vite-6.3.5
LOW CVE-2025-58751 Npm-vite-6.2.7
LOW CVE-2025-58752 Npm-vite-6.2.7

@BTreston BTreston marked this pull request as ready for review October 6, 2025 14:22
@BTreston BTreston requested a review from a team as a code owner October 6, 2025 14:22
@BTreston BTreston requested a review from jrmccannon October 6, 2025 14:22
@BTreston BTreston merged commit f722196 into main Oct 7, 2025
18 checks passed
@BTreston BTreston deleted the angular-v20 branch October 7, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants