Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18463] [PM-18465] At-risk Password Page Fixes #13573

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shane-melton
Copy link
Member

@shane-melton shane-melton commented Feb 26, 2025

🎟️ Tracking

PM-18463
PM-18465

📔 Objective

PM-18463

  • Fix missing hyphen in page description
  • Fix pluralization of page description when the user only has a single task
  • Fix spacing between UI buttons

PM-18465

  • Prevent autofill callout from flashing briefly after previously being dismissed

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@shane-melton shane-melton marked this pull request as ready for review February 26, 2025 01:01
@shane-melton shane-melton requested a review from a team as a code owner February 26, 2025 01:01
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.83%. Comparing base (44d50a7) to head (a85442f).

Files with missing lines Patch % Lines
...s/at-risk-passwords/at-risk-passwords.component.ts 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13573   +/-   ##
=======================================
  Coverage   35.83%   35.83%           
=======================================
  Files        3167     3167           
  Lines       93407    93411    +4     
  Branches    16999    17002    +3     
=======================================
+ Hits        33471    33475    +4     
  Misses      57345    57345           
  Partials     2591     2591           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details80f1aa43-bb96-4d98-9df3-a7b3d8957515

Great job, no security vulnerabilities found in this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant