[PM-18623][PM-18621][PM-18615] fix defects for new settings popover #13572

jaasen-livefront · 2025-02-25T23:33:47Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-18621
https://bitwarden.atlassian.net/browse/PM-18615
https://bitwarden.atlassian.net/browse/PM-18623

📔 Objective

This PR fixes a few defects from the new settings popover feature.

Link font should be bold
Link should be navigable via keyboard
Popover should not show when quick copy actions

📸 Screenshots

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov · 2025-02-25T23:35:31Z

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.83%. Comparing base (e0a3a05) to head (eca1a17).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
...settings-callout/new-settings-callout.component.ts	0.00%	7 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #13572   +/-   ##
=======================================
  Coverage   35.82%   35.83%           
=======================================
  Files        3166     3167    +1     
  Lines       93364    93411   +47     
  Branches    16994    17001    +7     
=======================================
+ Hits        33449    33471   +22     
- Misses      57326    57349   +23     
- Partials     2589     2591    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.