Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm 18493 pass relevant cipher name into confirmation UI #13570

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

dan-livefront
Copy link
Collaborator

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.76%. Comparing base (76fb5d4) to head (d9cc0d5).
Report is 23 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (76fb5d4) and HEAD (d9cc0d5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (76fb5d4) HEAD (d9cc0d5)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #13570       +/-   ##
===========================================
- Coverage   35.79%   15.76%   -20.04%     
===========================================
  Files        3164       27     -3137     
  Lines       93180     1884    -91296     
  Branches    16946        0    -16946     
===========================================
- Hits        33356      297    -33059     
+ Misses      57259     1587    -55672     
+ Partials     2565        0     -2565     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb926a14a-975e-45b5-9ce2-315b130004d6

New Issues (7)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
CRITICAL CVE-2025-24964 Npm-vitest-3.0.4 Vulnerable Package
HIGH CVE-2024-21538 Npm-cross-spawn-7.0.3 Vulnerable Package
MEDIUM Cx877cf216-175c Npm-event-pubsub-4.3.0 Vulnerable Package
MEDIUM Cx8ef77360-5422 Npm-node-ipc-9.2.1 Vulnerable Package
MEDIUM Cx949f3fb2-a0e5 Npm-js-message-1.0.7 Vulnerable Package
MEDIUM Cxafe14174-3b5a Npm-easy-stack-1.0.1 Vulnerable Package
MEDIUM Cxf62a1409-bb90 Npm-js-queue-2.0.2 Vulnerable Package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant