[CL-550] Fix popup layout padding and adjust views with extra bottom space #13562
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13562 +/- ##
=======================================
Coverage 35.82% 35.82%
=======================================
Files 3166 3166
Lines 93335 93372 +37
Branches 16991 16997 +6
=======================================
+ Hits 33435 33449 +14
- Misses 57314 57334 +20
- Partials 2586 2589 +3 ☔ View full report in Codecov by Sentry. |
|
Great job, no security vulnerabilities found in this Pull Request |
| @Input() mode: CipherFormConfig["mode"]; | ||
|
|
There was a problem hiding this comment.
I think it is more clear for the input name to describe its purpose:
@Input() disableMargin: boolean
Also makes sense because this is a composition of bit-section
| @@ -1,4 +1,4 @@ | |||
| <bit-section [formGroup]="sendOptionsForm"> | |||
| <bit-section [formGroup]="sendOptionsForm" disableMargin="true"> | |||
There was a problem hiding this comment.
nit: all of these disableMargin="true" could be simplified to disableMargin.
Probably not worth going back and updating everything though, unless that sounds fun to you.
There was a problem hiding this comment.
Incredibly fun, done
|
🎟️ Tracking
CL-550
📔 Objective
The generator page was missing some expected bottom padding. This was due to the popup page having a misconfigured height on one of its container divs. Fixing this led to uncovering issues with other pages that had been developed without accounting for the bottom padding, since it had not been working properly.
📸 Screenshots
Note the bottom margin of each page. (There are still some small discrepancies between the pages, based on the
itemcomponent having its own margin.)⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes